Fantastic advice! My boyfriend and I aren't planning on living together until we're actually married and I've encountered many people who think it's a bad idea, but those same people also either clearly envy, or have stated they wish they have the sort of healthy relationship my boyfriend and I have. (Silly, stupid people..)
We've been discussing everything you've listed except we only cover finances in a vague sense. I think we've only discussed it vaguely because, at the moment, neither of us are finished with school, I'm unemployed and living at home with an interest-free school loan from my parents. He's living off of a small fraction of some money that was left him. Other than the small loan with my parents (which, either I'm paying off my parents before wedding my boyfriend, or they're going to forgive my debt as a way of helping out/paying for the wedding. He, however, is debt free.
This is his last term in school, I'll be done with school in hopefully by either end of Spring or Summer of '10 and we're hoping to get engaged in a year as well.
Would you recommend, since we aren't going to live together until we're married, that we discuss how we'll manage our finances when we're married, before or after we get engaged?